Skip to content

fix: remove lerna legacy options #2854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

david-luna
Copy link
Contributor

@david-luna david-luna commented May 23, 2025

Which problem is this PR solving?

After the upgrade of lerna the release-please workflow fails due to legacy configuration that newer version does not accept. The failure message is

npx lerna publish from-package --no-push --no-private --no-git-tag-version --no-verify-access --yes
  shell: /usr/bin/bash -e {0}
  env:
    NPM_CONFIG_USERCONFIG: /home/runner/work/_temp/.npmrc
    NODE_AUTH_TOKEN: ***
    NPM_CONFIG_PROVENANCE: true
lerna notice cli v[8](https://github.com/open-telemetry/opentelemetry-js-contrib/actions/runs/15204321834/job/42764004634#step:10:9).2.2
lerna ERR! ECONFIGWORKSPACES The "useWorkspaces" option has been removed. By default lerna will resolve your packages using your package manager's workspaces configuration. Alternatively, you can manually provide a list of package globs to be used instead via the "packages" option in lerna.json

Also when fixing this issue another message appears about the no-verify-access CLI option.

npx lerna publish from-package --no-push --no-private --no-git-tag-version --no-verify-access --yes
lerna notice cli v8.2.2
lerna info versioning independent
lerna WARN verify-access --verify-access=false and --no-verify-access are no longer needed, because the legacy preemptive access verification is now disabled by default. Requests will fail with appropriate errors when not authorized correctly.

The option is needed since now is the default

Short description of the changes

@david-luna david-luna requested a review from a team as a code owner May 23, 2025 07:58
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!
thanks for following up on the broken workflow 🙂

@pichlermarc pichlermarc enabled auto-merge (squash) May 23, 2025 08:09
Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.69%. Comparing base (9ee8dc7) to head (43e2708).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2854      +/-   ##
==========================================
+ Coverage   89.64%   89.69%   +0.04%     
==========================================
  Files         184      184              
  Lines        9032     9032              
  Branches     1852     1852              
==========================================
+ Hits         8097     8101       +4     
+ Misses        935      931       -4     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pichlermarc pichlermarc merged commit 362e8b3 into open-telemetry:main May 23, 2025
19 of 20 checks passed
@david-luna david-luna deleted the dluna-lerna-workspaces-fix branch May 23, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants